From: Marco Trevisan (Treviño) <mail@3v1n0.net>
Date: Mon, 2 Sep 2019 12:01:36 +0000 (+0200)
Subject: extensionSystem: Use logError to record extension errors with stack trace
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~811^2^2~157
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=8a7e44ccf03fc1b10c43f21595f249a4a5061dfd;p=gnome-shell.git

extensionSystem: Use logError to record extension errors with stack trace

Extensions might emit JS errors explicitly or implicitly, however GNOME
Shell doesn't present any stack trace for those making them quite hard
to debug.

Make this easier by logging errors with logError() whichs includes the
stack dump.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/700
---

diff --git a/js/ui/extensionSystem.js b/js/ui/extensionSystem.js
index fd7196972..a668907f7 100644
--- a/js/ui/extensionSystem.js
+++ b/js/ui/extensionSystem.js
@@ -194,7 +194,7 @@ var ExtensionManager = class {
             extension.errors = [];
         extension.errors.push(message);
 
-        log('Extension "%s" had error: %s'.format(uuid, message));
+        logError(error, `Extension ${uuid}`);
         this.emit('extension-state-changed', extension);
     }